Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[various] Replaces manual hashing with Object.hash #5314

Merged
merged 6 commits into from
Apr 21, 2022
Merged

[various] Replaces manual hashing with Object.hash #5314

merged 6 commits into from
Apr 21, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

Updates hashValue implementations that were using manual XOR-based
hashing to use Object.hash. This brings them into alignment with the
majority of implementations in the repository (which were recently
updated from Flutter's hashValues to Object.hash)

Also does some opportunistic cleanup of cruft references
to pedantic in dev_dependencies that I noticed while
updating the pubspecs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[various] Replaces manual hashing with Object.hash
19fa139 
Updates `hashValue` implementations that were using manual XOR-based
hashing to use Object.hash. This brings them into alignment with the
majority of implementations in the repository (which were recently
updated from Flutter's `hashValues` to `Object.hash`)
@stuartmorgan-g
Copy link
Contributor Author

@hellohuanlin As promised :)

hellohuanlin
hellohuanlin approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful. thx for cleaning this up

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 21, 2022
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 21, 2022
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 21, 2022
@fluttergithubbot fluttergithubbot merged commit 85000d3 into flutter:main Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
85000d3ca [various] Replaces manual hashing with Object.hash (flutter…
d52d62b 
…/plugins#5314)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan-g @mauricioluz
[various] Replaces manual hashing with Object.hash (flutter#5314)
1126ae8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
p: camera p: local_auth p: video_player platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartmorgan-g @fluttergithubbot @blasten @hellohuanlin