Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 3, 2022

Bumps mockito-core from 3.2.4 to 4.6.1.

Release notes

Sourced from mockito-core's releases.

v4.6.1

Changelog generated by Shipkit Changelog Gradle Plugin

4.6.1

v4.6.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.6.0

v4.5.1

Changelog generated by Shipkit Changelog Gradle Plugin

4.5.1

Missing net.bytebuddy.utility.GraalImageCode exception

If you encounter any issues with missing ByteBuddy classes, make sure you are using ByteBuddy 1.12 or higher.

v4.5.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.5.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from camsim99 as a code owner June 3, 2022 11:10
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 3, 2022
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from ac9837c to fd4bffa Compare June 3, 2022 22:49
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from fd4bffa to 40c0b95 Compare June 22, 2022 23:09
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch 2 times, most recently from 3179306 to dd9c635 Compare July 11, 2022 17:24
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from dd9c635 to 5f8d165 Compare July 19, 2022 17:03
@stuartmorgan-g
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from 5f8d165 to 3db081d Compare July 21, 2022 02:23
@stuartmorgan-g
Copy link
Contributor

Looks like this will need some test updates for Mockito changes.

@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from 3db081d to 1decce1 Compare July 21, 2022 18:25
@Hixie
Copy link
Contributor

Hixie commented Jul 21, 2022

test-exempt: dependency roll

@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch 8 times, most recently from b47d8c1 to 85e9d43 Compare July 22, 2022 12:54
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.2.4 to 4.6.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.2.4...v4.6.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch from 85e9d43 to 29ac28d Compare July 22, 2022 13:43
…ackages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1
@camsim99 camsim99 requested a review from stuartmorgan-g August 3, 2022 22:11
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the version bump removed.

@@ -1,6 +1,11 @@
## 0.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only affects tests, which don't impact clients of the plugin, you can remove the version bump from the pubspec and just use NEXT here.

publishable may still flag it because of build.gradle, but since it's a testImplementation line that's a false positive that you can override with the label. (Currently it's not doing any line-level analysis of the diff, only looking at files. Eventually we should make it smarter.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I understand now. Ok thanks!

@camsim99 camsim99 added override: no versioning needed Override the check requiring version bumps for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Aug 4, 2022
@auto-submit auto-submit bot merged commit 5f2e02c into main Aug 4, 2022
@dependabot dependabot bot deleted the dependabot/gradle/packages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1 branch August 4, 2022 17:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App dependencies Pull requests that update a dependency file needs tests override: no versioning needed Override the check requiring version bumps for most changes p: quick_actions platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants