It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Maintainers, please let me know what I need to add/update more for passing tests. I am new to contributing to the flutter/* open source.

Thanks

This pull is not ready to by reviewed for now

@blasten @stuartmorgan
The USE_FINGERPRINT is deprecated from API 28. In the code, there's implementation done for using biometrics for API 28 and higher and use fingerprint manager for less than that. How do we add biometric permission just for API 29 and higher but keep the fingerprint permission for API versions below 29?

I just added the USE_BIOMETRIC instead but that will add errors in the FingerprintManager, it requires USE_FINGERPRINT permission.

I am new to open source. I've marked this pull as draft. Thanks for the support.

How do we add biometric permission just for API 29 and higher but keep the fingerprint permission for API versions below 29?

You can't; what's in the manifest is decided at build time, not runtime.

If you want to remove the need for this permission you'll need to restructure the code somewhat so that it doesn't use FingerprintManager at all. Since the primary flow uses an AndroidX library that internally falls back to fingerprints on older versions, that should be doable.

Maintainers, please let me know what I need to add/update more for passing tests.

The "Details" link for publishable will tell you why it is failing. The steps you skipped in the checklist have useful links for resolving that failure.

Maintainers, please let me know what I need to add/update more for passing tests.

The "Details" link for publishable will tell you why it is failing. The steps you skipped in the checklist have useful links for resolving that failure.

Thank you @stuartmorgan for the help. I'll check and continue on that.

If you want to remove the need for this permission you'll need to restructure the code somewhat so that it doesn't use FingerprintManager at all.

This was done in #6059, so you could update this PR to just update the local_auth README and example.

@stuartmorgan Okay works! I'll update the README and example.

Thanks

@stuartmorgan

• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.

These steps are needed for the local_auth change. (local_auth_android's change only affects running a local checkout, so doesn't need them.)

I am not 100% sure if I should update the version from 2.1.0 to 2.1.1? Or just update to 2.1.0+1?

Yes as our change in the example doesn't fall into:

PRs that only affect unpublished parts of example apps.

I think we should increase the version to 2.1.1

Sorry for the commits, I messed up with the message

Fixed the commit message issue

Please, let me know if there is still pending stuff. I'll update them ASAP. Thanks

Or just update to 2.1.0+1?

We follow the guidance at https://dart.dev/tools/pub/versioning#semantic-versions (linked from the PR checklist), and do not use build numbers for anything >= 1.0.0.

Adding changelog override for local_auth_android per my comment above.

Thank you guys!