Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool] Handle dependabot commit messages #6127

Merged
merged 1 commit into from
Jul 21, 2022
Merged

[tool] Handle dependabot commit messages #6127

merged 1 commit into from
Jul 21, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

Follow-up to #6124; that version
works if the tooling actually gets the PR description, but due to
cirruslabs/cirrus-ci-docs#1029 we may get the
commit message instead, so we need to detect that as well.

Part of flutter/flutter#107942

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[tool] Handle dependabot commit messages
21c78a3 
Follow-up to flutter#6124; that version
works if the tooling actually gets the PR description, but due to
cirruslabs/cirrus-ci-docs#1029 we may get the
commit message instead, so we need to detect that as well.

Part of flutter/flutter#107942
@stuartmorgan-g stuartmorgan-g requested a review from camsim99 July 20, 2022 20:33
@stuartmorgan-g
Copy link
Contributor Author

@camsim99 Your question about how reliable that detection would be was extremely prophetic :)

camsim99
camsim99 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to hear my comment was prophetic but I hope this catches the rest of the cases!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2022
@auto-submit auto-submit bot merged commit 89eff49 into flutter:main Jul 21, 2022
@stuartmorgan-g stuartmorgan-g deleted the tool-dependabot-exemption-adjustment branch July 21, 2022 00:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
89eff491b [tool] Handle dependabot commit messages (flutter/plugins#6127
d4912ab 
)
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@stuartmorgan-g @yutaaraki-toydium
[tool] Handle dependabot commit messages (flutter#6127)
be2e959
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan-g @mauricioluz
[tool] Handle dependabot commit messages (flutter#6127)
a06e7eb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@camsim99 camsim99 camsim99 approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @camsim99