Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Add missing exports for multi image picking types #6155

Merged
merged 4 commits into from
Aug 2, 2022
Merged

[image_picker] Add missing exports for multi image picking types #6155

merged 4 commits into from
Aug 2, 2022

Conversation

PiotrMitkowski
Copy link
Contributor

@PiotrMitkowski PiotrMitkowski commented Jul 29, 2022 •
edited
Loading

Description

This is a fix for #5914, where newly added types (ImageOptions and MultiImagePickerOptions) haven't been exported outside of the interface package.

Related issues

flutter/flutter#65995

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jul 29, 2022

test-exempt: we should consider adding a lint for this, but that's a problem for the future

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 29, 2022
Open
stuartmorgan-g
stuartmorgan-g approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g requested a review from cyanglaz August 1, 2022 14:38
@stuartmorgan-g
Copy link
Contributor

@cyanglaz for second approval

cyanglaz
cyanglaz approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2022
@auto-submit auto-submit bot merged commit 5626f1f into flutter:main Aug 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2022
@engine-flutter-autoroll
5626f1fa4 [image_picker] Add missing exports for multi image picking …
e3bd83c 
…types (flutter/plugins#6155)
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@PiotrMitkowski @yutaaraki-toydium
[image_picker] Add missing exports for multi image picking types (flu…
4416098 
…tter#6155)
@PiotrMitkowski PiotrMitkowski deleted the image-picker-interface-export-fix branch September 1, 2022 06:42
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@PiotrMitkowski @mauricioluz
[image_picker] Add missing exports for multi image picking types (flu…
c34b715 
…tter#6155)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: image_picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiotrMitkowski @Hixie @stuartmorgan-g @cyanglaz