This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Fix incorrect json key in queryPurchasesAsync response
#6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a good candidate for dumbest bug that I missed this year. shrug In any case, we now have a test enforcing key spelling and overall success of the queryPurchasesAsync method. |
stuartmorgan-g
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
LGTM
We should strongly consider consolidating the magic keys that need to match Dart to a single list of constants somewhere, so it's easier to validate manually across languages.
(Longer term of course, we should move to Pigeon and just not have the potential for this problem at all.)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#107454