Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider_windows] bump dependency version of package:win32 in path_provider_windows #6176

Merged
merged 3 commits into from
Aug 3, 2022
Merged

[path_provider_windows] bump dependency version of package:win32 in path_provider_windows #6176

merged 3 commits into from
Aug 3, 2022

Conversation

CicadaCinema
Copy link
Contributor

@CicadaCinema CicadaCinema commented Aug 3, 2022 •
edited
Loading

The usage

plugins/packages/path_provider/path_provider_windows/lib/src/path_provider_windows_real.dart

Line 195 in b0bfab6

final Pointer<Utf16> moduleNameBuffer = wsalloc(MAX_PATH + 1);
of the wsalloc function stipulates at least v2.1.0 of package:win32

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • this PR is test-exempt.
  • All existing and new tests are passing.

@CicadaCinema CicadaCinema requested a review from cbracken as a code owner August 3, 2022 12:37
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft August 3, 2022 14:10
@CicadaCinema CicadaCinema changed the title bump dependency version of package:win32 in path_provider_windows [path_provider_windows] bump dependency version of package:win32 in path_provider_windows Aug 3, 2022
@CicadaCinema
Copy link
Contributor Author

sorry about this - I've added the relevant changelog entry, not sure why the submit-queue test is failing though

@CicadaCinema CicadaCinema marked this pull request as ready for review August 3, 2022 15:14
stuartmorgan-g
stuartmorgan-g approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@auto-submit auto-submit bot merged commit 66dfd2a into flutter:main Aug 3, 2022
@CicadaCinema CicadaCinema deleted the patch-1 branch August 3, 2022 22:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
66dfd2ad0 [path_provider_windows] bump dependency version of package:…
4a6a644 
…win32 in path_provider_windows (flutter/plugins#6176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
66dfd2ad0 [path_provider_windows] bump dependency version of package:…
a331a49 
…win32 in path_provider_windows (flutter/plugins#6176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
66dfd2ad0 [path_provider_windows] bump dependency version of package:…
44a081e 
…win32 in path_provider_windows (flutter/plugins#6176)
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@CicadaCinema @yutaaraki-toydium
[path_provider_windows] bump dependency version of package:win32 in p…
5efc081 
…ath_provider_windows (flutter#6176)
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@CicadaCinema @moisefeelin
[path_provider_windows] bump dependency version of package:win32 in p…
ebcf7c8 
…ath_provider_windows (flutter#6176)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@CicadaCinema @mauricioluz
[path_provider_windows] bump dependency version of package:win32 in p…
44781d5 
…ath_provider_windows (flutter#6176)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cbracken cbracken cbracken approved these changes

@timsneath timsneath Awaiting requested review from timsneath

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_provider platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CicadaCinema @stuartmorgan-g @cbracken