Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[various] Remove pedantic #6179

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[various] Remove pedantic #6179

merged 1 commit into from
Aug 3, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

We had pedantic in package pubspecs because it was used by the legacy
analysis options, but those no longer exist; the respository no longer
has any dependency on pedantic. In some cases we cleaned this up as we
migrated packages, but this cleans up all the remaining dependencies
that we forgot.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[various] Remove pedantic
5fa1d26 
We had `pedantic` in package pubspecs because it was used by the legacy
analysis options, but those no longer exist; the respository no longer
has any dependency on `pedantic`. In some cases we cleaned this up as we
migrated packages, but this cleans up all the remaining dependencies
that we forgot.
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 3, 2022
@stuartmorgan-g
Copy link
Contributor Author

No version changes because removing dev_dependencies doesn't affect client.
No CHANGELOG change because removing a dev dependency that wasn't being used anyway is uninteresting.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@auto-submit
Copy link

auto-submit bot commented Aug 3, 2022

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@auto-submit auto-submit bot merged commit 5c5d7ae into flutter:main Aug 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
5c5d7ae2d [various] Remove pedantic (flutter/plugins#6179)
702ee9f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
5c5d7ae2d [various] Remove pedantic (flutter/plugins#6179)
9dedc0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
5c5d7ae2d [various] Remove pedantic (flutter/plugins#6179)
1a6d0e5
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@stuartmorgan-g @yutaaraki-toydium
[various] Remove pedantic (flutter#6179)
f68a894
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@stuartmorgan-g @moisefeelin
[various] Remove pedantic (flutter#6179)
46e1e74
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan-g @mauricioluz
[various] Remove pedantic (flutter#6179)
83e0b4d
@jmagman jmagman mentioned this pull request Feb 15, 2023
Closed
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@GaryQian GaryQian Awaiting requested review from GaryQian

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: espresso p: file_selector p: flutter_plugin_android_lifecycle p: google_maps_flutter p: in_app_purchase p: ios_platform_images p: local_auth p: path_provider p: plugin_platform_interface p: quick_actions p: shared_preferences p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios platform-linux platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @gaaclarke