Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Updating expiring cirrus key. #6237

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Updating expiring cirrus key. #6237

merged 1 commit into from
Aug 12, 2022

Conversation

yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented Aug 12, 2022

Bug:#109367

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@keyonghan
Copy link
Contributor

The GCLOUD_FIREBASE_TESTLAB_KEY needs an update too:
https://github.com/flutter/plugins/blob/main/.cirrus.yml#L249

Note, this should be different from the gcp_credentials. Refer to the last two items in go/flutter-cirrus#setup (create a separate encrypted-variable in flutter/plugins repo).

@yusuf-goog
Copy link
Contributor Author

done

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yusuf-goog yusuf-goog self-assigned this Aug 12, 2022
@yusuf-goog yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2022
@auto-submit auto-submit bot merged commit 2b1ace0 into flutter:main Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants