This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] code excerpts in README #6296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
suggested changes
Aug 20, 2022
|
@stuartmorgan looks like I forgot to re-remove that line after a resync. All requests complete. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
* update README to pull code excerpts from basic * update version to 2.4.6 * new line * fix dart issues * update to match snippet * re-remove video_player from exclusion list * add . * sync readme to snippet * Roll Flutter from 663bb66 to 723609b (29 revisions) (flutter#6297) * Roll Flutter from 723609b to 9d78b2f (6 revisions) (flutter#6298) Co-authored-by: engine-flutter-autoroll <[email protected]>
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* update README to pull code excerpts from basic * update version to 2.4.6 * new line * fix dart issues * update to match snippet * re-remove video_player from exclusion list * add . * sync readme to snippet * Roll Flutter from 663bb66 to 723609b (29 revisions) (flutter#6297) * Roll Flutter from 723609b to 9d78b2f (6 revisions) (flutter#6298) Co-authored-by: engine-flutter-autoroll <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated README to pull code from new basic.dart example file
issue#102679
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.