Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Migrate ThemeData.errorColor #6310

Merged
merged 2 commits into from
Aug 25, 2022
Merged

[in_app_purchase] Migrate ThemeData.errorColor #6310

merged 2 commits into from
Aug 25, 2022

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Aug 24, 2022 •
edited by cyanglaz
Loading

This is to enable flutter/flutter#110162 to land.

Related to flutter/flutter#91772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl marked this pull request as ready for review August 24, 2022 19:31
@guidezpl guidezpl changed the title [in_app_purchase] Migrate ThemeData.errorColor [in_app_purchase] Migrate ThemeData.errorColor Aug 24, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cyanglaz
Copy link
Contributor

Don't need version updates, changes are example app only.

@guidezpl Could you make sure the check list in this PR description matches the change in this PR? (For example, you checked I listed at least one issue that this PR fixes in the description above. which is not true)

@Hixie
Copy link
Contributor

Hixie commented Aug 24, 2022

test-exempt: refactor with no semantic change

@guidezpl
Copy link
Member Author

Don't need version updates, changes are example app only.

@guidezpl Could you make sure the check list in this PR description matches the change in this PR? (For example, you checked I listed at least one issue that this PR fixes in the description above. which is not true)

Done

@guidezpl guidezpl added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 25, 2022
cyanglaz
cyanglaz approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 0c7b4e7 into main Aug 25, 2022
@guidezpl guidezpl deleted the anticipate-deprecations branch August 25, 2022 17:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
0c7b4e742 [in_app_purchase] Migrate ThemeData.errorColor (flutter/p…
f23e4ae 
…lugins#6310)
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@guidezpl @moisefeelin
[in_app_purchase] Migrate ThemeData.errorColor (flutter#6310)
4c2fc2e 
* Migrate ThemeData.errorColor

* x
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@guidezpl @mauricioluz
[in_app_purchase] Migrate ThemeData.errorColor (flutter#6310)
25cd7b9 
* Migrate ThemeData.errorColor

* x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryQian GaryQian GaryQian approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: in_app_purchase platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guidezpl @cyanglaz @Hixie @GaryQian