[google_maps_flutter] Update Android view selection #6319
Conversation
Fixes the `useAndroidViewSurface` flag for Flutter 3.0+. Because of the way TLHC rolled out, `useAndroidViewSurface` was no longer doing anything meaningful, since either way TLHC would actually be used. This updates that flag to use `initExpensiveAndroidView` to force HC, so that the switch does something again. This provides a way to work around the maps TLHC issue tracked in flutter/flutter#103686
This comment was marked as resolved.
This comment was marked as resolved.
|
|
||
| * Fixes violations of new analysis option use_named_constants. | ||
| * Fixes avoid_redundant_argument_values lint warnings and minor typos. | ||
| * Updates `useAndroidViewSurface` to require Hybrid Composition, making the |
There was a problem hiding this comment.
nit: Should this include that the minimum Flutter version was raised to 3.0.0.
There was a problem hiding this comment.
Can't hurt certainly! Done.
|
|
||
| environment: | ||
| sdk: ">=2.14.0 <3.0.0" | ||
| flutter: ">=2.8.0" | ||
| flutter: ">=3.0.0" |
There was a problem hiding this comment.
Just out of curiosity, would this also cause the downgrade analyze test to fail for google_maps_flutter package. It would make the minimum Flutter version it could use 3.0.0 on Android, but could still use 2.8.0 for iOS.
There was a problem hiding this comment.
Nope, the resolver just won't pick this version if you're on an older version of Flutter. Updating the minimum version of the implementation package required by the app-facing package is what would require us to update the app-facing min version.
This is a small perk of federation; for now people can get updates to anything but the Android implementation even on old versions.
Fixes the
useAndroidViewSurfaceflag for Flutter 3.0+. Because of theway TLHC rolled out,
useAndroidViewSurfacewas no longer doinganything meaningful, since either way TLHC would actually be used.
This updates that flag to use
initExpensiveAndroidViewto force HC, sothat the switch does something again.
This provides a way to work around the maps TLHC issue tracked in
flutter/flutter#103686
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.