[file_selector] Endorse ios and update examples #6320
Conversation
packages/file_selector/file_selector/example/lib/get_directory_page.dart
Outdated
Show resolved
Hide resolved
packages/file_selector/file_selector/example/lib/save_text_page.dart
Outdated
Show resolved
Hide resolved
| { | ||
| "size" : "20x20", | ||
| "idiom" : "iphone", | ||
| "filename" : "[email protected]", |
There was a problem hiding this comment.
@stuartmorgan do we usually actually check these binary images in? That seems unnecessary...
There was a problem hiding this comment.
They are in other ios plugin example folders as well, not to imply they should be.
There was a problem hiding this comment.
Yes, this came up recently in a different repo; we usually just run flutter create and basically leave it alone for the examples, because everyone trying to remember all of the things we want to change, across all the platforms, would be a nightmare.
We could potentially make repo tooling that would check examples for all the things we want to clean up about them so that it wouldn't require extra thought, it just hasn't been something that's been an issue so far.
From a repo standpoint the ship has largely sailed since we have copies already (although I guess they do rarely change, like the iOS corner change). I guess it would make a very small on-disk difference to developers using the plugin?
There was a problem hiding this comment.
They are small, I wouldn't care so much about the plugin developers needing to download these images (though why?) but also that we're checking in binaries to the git history that will be there forever (without editing history https://stackoverflow.com/questions/10622179/how-to-find-identify-large-commits-in-git-history). I think binaries are special in this case. We don't check them into the flutter/flutter repo example projects, for example.
Up to you though, I don't have a strong preference.
There was a problem hiding this comment.
Filed flutter/flutter#110523
but also that we're checking in binaries to the git history that will be there forever
Right, it would be good to stop. But incremental copies of the images we already have are basically free because of how git works, so we only pay again when flutter create actually changes images.
* Endorse ios and update examples * [gh_actions]: Bump lewagon/wait-on-check-action from 1.1.1 to 1.1.2 (flutter#6300) * [gh_actions]: Bump github/codeql-action from 2.1.18 to 2.1.19 (flutter#6299) * [gh_actions]: Bump ossf/scorecard-action from 1.1.1 to 1.1.2 (flutter#6071) * Roll Flutter from abfba69 to 6d3f782 (74 revisions) (flutter#6314) * [gh_actions]: Bump actions/labeler from 4.0.0 to 4.0.1 (flutter#6262) * Roll Flutter from 6d3f782 to 000b96c (13 revisions) (flutter#6317) * Adds info about commands requiring Flutter-bundled dart (flutter#6312) * [tools] Validate code excerpt configuration (flutter#6286) * temp lower ios version number * Update README supported table * remove unused routes * lower version num * iOS vs ios * todo * don't ignore ios * add ios files * add license block * fix Uint8 error * relocate import * Exclude ios integration test for file_selector * fix requests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: stuartmorgan <[email protected]> Co-authored-by: Tarrin Neal <[email protected]>
Endorses ios plugin for file_selector plugin. This includes updating the file_selector examples to make it clear they won't function on ios, and prevent them from failing.
List which issues are fixed by this PR. You must list at least one issue.
fixes flutter/flutter#110097
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.