[in_app_purchase] Replace errorColor to land deprecations (Part 2) #6417
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
| ## 0.3.3 | |||
There was a problem hiding this comment.
Since this is just a change in the example app, you don't need to bump the version.
There was a problem hiding this comment.
I was told the exact opposite here😅
There was a problem hiding this comment.
Apologies. Should it be a patch version then? 0.3.2+1?
There was a problem hiding this comment.
I've typically avoided it as Dart recommends not using + after 1.0.0.
There was a problem hiding this comment.
0.3 is less than 1.0.0 🙂 @jmagman is correct that this should be 0.3.2+1, because we follow the guidance that you linked to:
Although semantic versioning doesn’t promise any compatibility between versions prior to 1.0.0, the Dart community convention is to treat those versions semantically as well. The interpretation of each number is just shifted down one slot: going from 0.1.2 to 0.2.0 indicates a breaking change, going to 0.1.3 indicates a new feature, and going to 0.1.2+1 indicates a change that doesn’t affect the public API.
Anticipate deprecations from flutter/flutter#110848, apparently missed one from #6377.
Related flutter/flutter#91772
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.