Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] flip/change camera while recording #6478

Closed
wants to merge 120 commits into from
Closed

[camera] flip/change camera while recording #6478

wants to merge 120 commits into from

Conversation

BradenBagby
Copy link
Contributor

@BradenBagby BradenBagby commented Sep 23, 2022 •
edited
Loading

Allow switching the camera while recording as requested here flutter/flutter#82467

Currently works for Android and iOS

Possible breaking change: moves cameraDescription from the CameraController to the CameraValue because it can now change without re-initializing a whole new controller. This can be changed if there is a better way

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@BradenBagbyWavv
setDescription in Camera platform interface
dcf5051
@BradenBagbyWavv
Merge remote-tracking branch 'upstream/main' into feature/switch-camera
6ebbf8f
@BradenBagbyWavv
example app setup to change description mid recording
ffd30f0
@BradenBagbyWavv
AVFoundationCamera method call to setDescription
bc9e8b9
@BradenBagbyWavv
FLTCam setup to setDescription
89accd6
@BradenBagbyWavv
captureSession split into video and audio so we will be able to switc…
e31ba2a 
…h cameras without breaking the audio
@BradenBagbyWavv
renamed setDescription to setDescriptionWhileRecording since it can o…
ac2c249 
…nly be used while recording
@BradenBagbyWavv
integration tests fixed
1516e0d
@BradenBagbyWavv
set description while recording integration test
34b9b03
@BradenBagbyWavv
throws error if device not recording and setDescriptionWhileRecording…
97f9733 
… is called
@BradenBagbyWavv
set description while recording test
bca93e2
@BradenBagbyWavv
example project setup
b999be1
@BradenBagbyWavv
camera preview can be changed while recording
568af7d
@BradenBagbyWavv
camera switches and keeps surface pointed to mediarecorder
ef4f96b
@BradenBagbyWavv
small change to set autofocus when switching while recording
f36004d
@BradenBagbyWavv
android video record goes through VideoRenderer to apply matrix after…
a0301c2 
… switching camera
@BradenBagbyWavv
switch camera uses VideoRenderer
e929814
@BradenBagbyWavv
dont use video renderer until user switches camera while recording
156f78a
@BradenBagbyWavv
rotate based on initial recording direction
61468a9
@BradenBagbyWavv
VideoRenderer cleanup
aea9067
@BradenBagbyWavv
flutter results for setDescriptionWhileRecording
fdf5738
@BradenBagbyWavv
error if you setDescriptionWhileRecording while device is not recording
d9862f3
@BradenBagbyWavv
android tests
a20e5d3
@BradenBagbyWavv
integration tests
5044d94
@BradenBagbyWavv
method channel test
667c803
@BradenBagbyWavv
main package tests
3b45ff5
@BradenBagbyWavv
setDescriptionWhileRecording called while no video was recording test
5d96ffd
@BradenBagbyWavv
integration tests
aa1d070
@BradenBagbyWavv
dependency overrides
858ce2e
@BradenBagbyWavv
update readme and version
58bdcf6
@BradenBagby
Copy link
Contributor Author

@stuartmorgan all of your comments have been addressed. setDescription can now be called anytime, the CameraController handles it correctly depending on if its mid recording or not, then updates its state.

I want to write tests on calling setDescription while not recording. I will get that done very soon.

@BradenBagby
Copy link
Contributor Author

Alright those other tests are created and this is ready for review again @stuartmorgan

stuartmorgan-g
stuartmorgan-g reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses my high-level API concern. @bparrishMines Can you re-review the app-facing package's API changes to make sure you are happy with this version?

Since that re-review is limited to the app-facing package, @BradenBagby feel free to start splitting out the sub-PRs (starting with the platform interface) in parallel with that process.

@BradenBagby BradenBagby mentioned this pull request Jan 23, 2023
Merged
@BradenBagby
Copy link
Contributor Author

BradenBagby commented Jan 23, 2023 •
edited
Loading

@bparrishMines @stuartmorgan The split out PR for the platform interface is ready here: #7011

bparrishMines
bparrishMines approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM App-facing package

@BradenBagby BradenBagby mentioned this pull request Feb 6, 2023
Merged
@BradenBagby
Copy link
Contributor Author

The split out PR for camera_avfoundation and camera_android is here @hellohuanlin @camsim99 @bparrishMines
#7109

@hellohuanlin hellohuanlin mentioned this pull request Feb 15, 2023
Closed
@stuartmorgan-g
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

@BradenBagby BradenBagby mentioned this pull request Feb 22, 2023
Merged
@BradenBagby BradenBagby mentioned this pull request Mar 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@loic-sharma loic-sharma loic-sharma left review comments

@Silipok Silipok Silipok left review comments

@abdullah-onus abdullah-onus abdullah-onus left review comments

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@camsim99 camsim99 camsim99 approved these changes

Assignees
No one assigned
Labels
p: camera platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.