This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker_windows] Annotate XTypeGroup constructor with // ignore: prefer_const_constructors #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Sep 29, 2022
|
|
||
| * Prepares this package to use a const constructor of XTypeGroup. |
There was a problem hiding this comment.
The version and changelog changes can be reverted; ignores are exempt.
cbracken
approved these changes
Sep 30, 2022
stuartmorgan-g
approved these changes
Sep 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2022
… // ignore: prefer_const_constructors (flutter/plugins#6504)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2022
… // ignore: prefer_const_constructors (flutter/plugins#6504)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2022
… // ignore: prefer_const_constructors (flutter/plugins#6504)
11 tasks
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
…: prefer_const_constructors (flutter#6504)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…: prefer_const_constructors (flutter#6504)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate XTypeGroup with // ignore: prefer_const_constructors to prepare this package for the latest version of the XTypeGroup constructor.
This includes a pump version of the package, but maybe it's not needed, please let us know if we need to revert this changes.
Issue:
#111906 [file_selector]
XTypeGroupshould be immutableRelated PR:
[file_selector] Convert XTypeGroup to const
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.