Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Update pubspec.yaml #6525

Closed
wants to merge 1 commit into from

Conversation

giorgio79
Copy link

@giorgio79 giorgio79 commented Oct 1, 2022

Need to reflect google play billing update for android in the main in_app_purchase plugin

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Need to reflect google play billing update for android in the main in_app_purchase plugin
@google-cla
Copy link

google-cla bot commented Oct 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@giorgio79 giorgio79 changed the title Update pubspec.yaml [in_app_purchase] Update pubspec.yaml Oct 1, 2022
@bparrishMines
Copy link
Contributor

@giorgio79 Is this version bump required? Could a user not just call pub upgrade to pull the latest version of the dependency?

@giorgio79
Copy link
Author

giorgio79 commented Oct 4, 2022 via email

@bparrishMines
Copy link
Contributor

Are you submitting the app after building it with the latest in_app_purchase_android version? If so, this version bump won't solve that problem. Your pubspec.lock should tell you which version you're using.

@stuartmorgan-g
Copy link
Contributor

Summarizing from offline discussion: we generally don't require updates to transitive dependencies, but there's something of a special case here since updating the Android implementation package is necessary. Enough people who don't run flutter pub upgrade are getting confused about this that bumping to 0.2.3 (not +5) would be reasonable here.

@stuartmorgan-g
Copy link
Contributor

it seems a simple pub upgrade won't do

Are you sure you ran flutter pub upgrade, not flutter pub get? You should only still be using the old version of the implementation package if you did the latter.

@giorgio79
Copy link
Author

I haven't had in_app_purchase_android in my pubspec list as the plain in_app_purchase package https://github.com/flutter/plugins/blob/main/packages/in_app_purchase/in_app_purchase/pubspec.yaml includes it in the pubspec.yaml, but an older version!

I always run flutter pub upgrade when I edit the codebase, so everything was up to date. You need to have in_app_purchase_android in the pubspec to resolve this issue, which I did now, and the alert is gone, but the only reason I installed in_app_purchase_android separately is to make this issue go away.

@stuartmorgan-g
Copy link
Contributor

I haven't had in_app_purchase_android in my pubspec

That is normal. flutter pub upgrade updates transitive dependencies as well.

in_app_purchase package includes it in the pubspec.yaml, but an older version!

That's a minimum range constraint, not a pinned version. It will resolve to the latest version less than 0.3.0, which includes 0.2.3+5.

I always run flutter pub upgrade when I edit the codebase, so everything was up to date.

If you still have the version where you saw this in version control, please file an issue and provide the output of flutter pub outdated and flutter pub upgrade when run against that version. If running upgrade didn't update your transitive dependencies that's a bug.

You need to have in_app_purchase_android in the pubspec to resolve this issue

This should not be the case.

@bparrishMines
Copy link
Contributor

closing in favor of #6595

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants