-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Update pubspec.yaml #6525
Conversation
Need to reflect google play billing update for android in the main in_app_purchase plugin
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@giorgio79 Is this version bump required? Could a user not just call |
Don't know. I am still getting Google Play warning when submitting the app,
so it seems a simple pub upgrade won't do ( I don't have the android
version on my pubspec list.
…On Tue, Oct 4, 2022, 18:07 Maurice Parrish ***@***.***> wrote:
@giorgio79 <https://github.com/giorgio79> Is this version bump required?
Could a user not just call pub upgrade to pull the latest version of the
dependency?
—
Reply to this email directly, view it on GitHub
<#6525 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFFU4FEA2RS3HQVGNEVBTWBRI4RANCNFSM6AAAAAAQ2RNIHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Are you submitting the app after building it with the latest |
Summarizing from offline discussion: we generally don't require updates to transitive dependencies, but there's something of a special case here since updating the Android implementation package is necessary. Enough people who don't run |
Are you sure you ran |
I haven't had in_app_purchase_android in my pubspec list as the plain in_app_purchase package https://github.com/flutter/plugins/blob/main/packages/in_app_purchase/in_app_purchase/pubspec.yaml includes it in the pubspec.yaml, but an older version! I always run flutter pub upgrade when I edit the codebase, so everything was up to date. You need to have in_app_purchase_android in the pubspec to resolve this issue, which I did now, and the alert is gone, but the only reason I installed in_app_purchase_android separately is to make this issue go away. |
That is normal.
That's a minimum range constraint, not a pinned version. It will resolve to the latest version less than 0.3.0, which includes 0.2.3+5.
If you still have the version where you saw this in version control, please file an issue and provide the output of
This should not be the case. |
closing in favor of #6595 |
Need to reflect google play billing update for android in the main in_app_purchase plugin
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.