[camera] Remove usage of `_ambiguate` method in example #6555

nilsreichardt · 2022-10-09T14:39:12Z

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-10-09T14:39:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

nilsreichardt · 2022-10-09T14:40:11Z

packages/camera/camera/example/pubspec.yaml

@@ -4,7 +4,7 @@ publish_to: none

 environment:
  sdk: ">=2.14.0 <3.0.0"


Should we also update the minimum Dart SDK because Flutter 3 requires +2.17?

We generally only update the Dart version if we are actually enabling or requiring some new Dart functionality. This change is only about a Flutter API change, not a Dart change.

nilsreichardt · 2022-10-09T14:40:28Z

packages/camera/camera/pubspec.yaml

@@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
  Dart.
 repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.10.0+3
+version: 0.10.0+4


Just updating the patch version because only the example code has been changed.

nilsreichardt · 2022-10-09T14:41:23Z

packages/camera/camera/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.10.0+4
+
+* Removes usages of `_ambiguate` method in example.


Is this enough or should it be more descriptive?

nilsreichardt · 2022-10-09T14:42:41Z

@stuartmorgan Is this structure okay? If yes, I would also remove the _ambiguate method in the other plugins 👍

nilsreichardt · 2022-10-09T14:43:22Z

Should I request a test exempt or add tests for this? If yes, how?

stuartmorgan-g

This should qualify for a test exemption since it's conceptually just code removal.

stuartmorgan-g · 2022-10-10T15:49:48Z

packages/camera/camera/example/pubspec.yaml

@@ -4,7 +4,7 @@ publish_to: none

 environment:
  sdk: ">=2.14.0 <3.0.0"
-  flutter: ">=2.10.0"
+  flutter: ">=3.0.0"


You'll need to change the requirements for camera itself too, since we can't guarantee we won't break 2.10 going forward if we can't run the example.

Bumped it to Flutter 3.0 also for camera 👍 Is it then still just a patch update? For v0.10.0+2 this was case

Yes; dropping support for old versions isn't a breaking change because the pub resolver just won't even include it.

stuartmorgan-g

LGTM, thanks!

stuartmorgan-g · 2022-10-10T16:14:56Z

@bparrishMines for secondary review.

nilsreichardt · 2022-10-10T16:23:56Z

Thanks for the review and fixing the typos, @stuartmorgan ❤️

Hixie · 2022-10-11T18:20:06Z

test-exempt: code removal

on a personal note, thank you for cleaning up my mess!

bparrishMines

LGTM

ditman · 2022-10-20T19:08:33Z

Woops, this seems to have broken main?

* `dart analyze` found the following issue(s):
  Analyzing camera...
  
    error - example/integration_test/camera_test.dart:12:8 - Target of URI doesn't exist: 'package:integration_test/integration_test.dart'. Try creating the file referenced by the URI, or try using a URI for a file that does exist. - uri_does_not_exist
    error - example/integration_test/camera_test.dart:13:8 - Target of URI doesn't exist: 'package:path_provider/path_provider.dart'. Try creating the file referenced by the URI, or try using a URI for a file that does exist. - [...]ges
     info - example/integration_test/camera_test.dart:13:8 - The imported package 'path_provider' isn't a dependency of the importing package. Try adding a dependency for 'path_provider' in the 'pubspec.yaml' file. - depend_on_referenced_packages
     info - example/test/main_test.dart:5:8 - The imported package 'camera_example' isn't a dependency of the importing package. Try adding a dependency for 'camera_example' in the 'pubspec.yaml' file. - depend_on_referenced_packages
  
  9 issues found.

https://github.com/flutter/plugins/runs/9014078499

stuartmorgan-g · 2022-10-20T19:31:27Z

The breakage looks like it's latent due to a recent change to how publish --dry-run works. It's OOB breakage because the dry-run test doesn't actually do anything on rolls, since there's nothing to publish, so all the rest of the pub checks are bypassed :( I'll file an issue; maybe we should fake-bump the version before running that check.

…utter/plugins#6555)

nilsreichardt added 4 commits October 9, 2022 16:35

Remove usage of _ambiguate in example/main.dart

9503585

Bump Flutter version to 3.0.0 in example

ed0003f

Bump version of camera

c24b664

Update CHANGELOG.md of camera

4fa7f70

nilsreichardt requested a review from bparrishMines as a code owner October 9, 2022 14:39

flutter-dashboard bot added the needs tests label Oct 9, 2022

github-actions bot added the p: camera label Oct 9, 2022

Fix typo

4cb7077

nilsreichardt commented Oct 9, 2022

View reviewed changes

stuartmorgan-g suggested changes Oct 10, 2022

View reviewed changes

nilsreichardt and others added 3 commits October 10, 2022 17:57

Bump Flutter version to 3.0

10b0b7b

Typo fix

5d21a9d

Second typo fix

16e23dc

stuartmorgan-g reviewed Oct 10, 2022

View reviewed changes

stuartmorgan-g approved these changes Oct 10, 2022

View reviewed changes

bparrishMines approved these changes Oct 20, 2022

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2022

auto-submit bot merged commit 09a4a09 into flutter:main Oct 20, 2022

stuartmorgan-g mentioned this pull request Oct 20, 2022

Plugin tooling publishable can have out-of-band errors flutter/flutter#113788

Closed

engine-flutter-autoroll mentioned this pull request Oct 21, 2022

Roll Plugins from a577c004a4b9 to 7a7480a5f392 (4 revisions) flutter/flutter#113834

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2022

09a4a096d [camera] Remove usage of _ambiguate method in example (fl…

ca97706

…utter/plugins#6555)

adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022

[camera] Remove usage of _ambiguate method in example (flutter#6555)

1bb8253

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[camera] Remove usage of _ambiguate method in example (flutter#6555)

1cd9f89

		@@ -4,7 +4,7 @@ publish_to: none

		environment:
		sdk: ">=2.14.0 <3.0.0"

		@@ -1,3 +1,8 @@
		## 0.10.0+4

		* Removes usages of `_ambiguate` method in example.

[camera] Remove usage of _ambiguate method in example #6555

[camera] Remove usage of _ambiguate method in example #6555

Uh oh!

Conversation

nilsreichardt commented Oct 9, 2022

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Oct 9, 2022

Uh oh!

nilsreichardt Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

nilsreichardt Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

nilsreichardt Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

nilsreichardt commented Oct 9, 2022

Uh oh!

nilsreichardt commented Oct 9, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

nilsreichardt Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Oct 10, 2022

Uh oh!

nilsreichardt commented Oct 10, 2022

Uh oh!

Hixie commented Oct 11, 2022

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Oct 20, 2022

Uh oh!

Uh oh!

[camera] Remove usage of `_ambiguate` method in example #6555

[camera] Remove usage of `_ambiguate` method in example #6555

ditman commented Oct 20, 2022 •

edited

Loading