Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool] Get dependencies in package examples before publish check. #6596

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Oct 20, 2022

It seems that dart pub publish --dry-run is failing in main because dependencies for example directories are not being fetched, which is causing new analyze errors that weren't being surfaced before. See: dart-lang/pub#3618.

This PR modifies the publish-check command to recurse into every example of each package being analyzed, and getting its dependencies before the actual pub publish command runs.

Works around: dart-lang/pub#3618

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [~] I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g October 20, 2022 23:05
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@ditman ditman added warning: land on red to fix tree breakage label to override luci-status signal autosubmit Merge PR when tree becomes green via auto submit App labels Oct 20, 2022
@auto-submit auto-submit bot merged commit 3a03925 into flutter:main Oct 20, 2022
@ditman ditman deleted the pub-get-before-publish-check branch October 21, 2022 00:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@ditman ditman self-assigned this Nov 4, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage label to override luci-status signal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants