This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[tool] Get dependencies in package examples before publish check. #6596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
dart pub publish --dry-run
is failing inmain
because dependencies forexample
directories are not being fetched, which is causing new analyze errors that weren't being surfaced before. See: dart-lang/pub#3618.This PR modifies the
publish-check
command to recurse into every example of each package being analyzed, and getting its dependencies before the actualpub publish
command runs.Works around: dart-lang/pub#3618
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.