Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix strict language checks #6622

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Fix strict language checks #6622

merged 2 commits into from
Oct 26, 2022

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 26, 2022

The strict- values are meant to be used via the language key

See https://dart.dev/guides/language/analysis-options

@kevmoo
Fix strict language checks
5f2d48b 
The strict- values are meant to be used via the language key

See https://dart.dev/guides/language/analysis-options
@kevmoo kevmoo requested a review from stuartmorgan-g October 26, 2022 05:15
@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 26, 2022

VERY weird things got into this state!

stuartmorgan-g
stuartmorgan-g approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

It's not that strange: I messed up when updating this because I didn't notice the different key. Thanks for catching it!

@stuartmorgan-g
Copy link
Contributor

Oh, analyze is failing now. I'll take a look later this morning.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 26, 2022
@stuartmorgan-g
Copy link
Contributor

Adding overrides for google_sign_in_web since the check doesn't detect comment-only changes.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot merged commit cd8bb0a into main Oct 26, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2022
@engine-flutter-autoroll
cd8bb0a20 Fix strict language checks (flutter/plugins#6622)
892172f
@kevmoo kevmoo deleted the fix_analysis_options branch October 26, 2022 17:29
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@kevmoo
Fix strict language checks (flutter#6622)
74f9f87
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@kevmoo @mauricioluz
Fix strict language checks (flutter#6622)
bdabdd8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: google_sign_in p: in_app_purchase platform-ios platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @stuartmorgan-g