This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci]Temporarily disable starqlteue on firebase device lab #6657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -258,7 +258,7 @@ task: | |||
firebase_test_lab_script: | |||
- if [[ -n "$GCLOUD_FIREBASE_TESTLAB_KEY" ]]; then | |||
- echo $GCLOUD_FIREBASE_TESTLAB_KEY > ${HOME}/gcloud-service-key.json | |||
- ./script/tool_runner.sh firebase-test-lab --device model=redfin,version=30 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml | |||
- ./script/tool_runner.sh firebase-test-lab --device model=redfin,version=30 --exclude=script/configs/exclude_integration_android.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could you add a TODO
comment that points to the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, done
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
* f8122dc89 [ci]Temporarily disable starqlteue on firebase device lab (flutter/plugins#6657) * 38c93242a [video_player]add integration test for inverted aspect ratio bug (flutter/plugins#6662) * dd8245e32 Roll Flutter (stable) from 6928314 to e99c9c7 (2 revisions) (flutter/plugins#6667) * 8cfa2652c Roll Flutter from 0e98194 to e6300da (46 revisions) (flutter/plugins#6668) * 897ec59cd [ci] Removes unnecessary overrides. (flutter/plugins#6669) * a279b9dd8 Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter/plugins#6670)
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
cyanglaz
pushed a commit
to cyanglaz/plugins
that referenced
this pull request
Nov 14, 2022
…utter#6657)" This reverts commit f8122dc.
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
…utter#6657)" (flutter#6710) This reverts commit f8122dc.
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#114689) * f8122dc89 [ci]Temporarily disable starqlteue on firebase device lab (flutter/plugins#6657) * 38c93242a [video_player]add integration test for inverted aspect ratio bug (flutter/plugins#6662) * dd8245e32 Roll Flutter (stable) from 6928314 to e99c9c7 (2 revisions) (flutter/plugins#6667) * 8cfa2652c Roll Flutter from 0e98194 to e6300da (46 revisions) (flutter/plugins#6668) * 897ec59cd [ci] Removes unnecessary overrides. (flutter/plugins#6669) * a279b9dd8 Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter/plugins#6670)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…utter#6657)" (flutter#6710) This reverts commit f8122dc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable starqlteue on firebase device lab to keep the roller running.
The starqlteue is having some infra issues. See Firebase community slack test-lab channel for discussions.
flutter/flutter#114535 is created to track en-enabling the device.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.