This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Implement interface methods to allow concurrent stream and record #6665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for having to create a new PR and lose the history from #6290. I couldn't find a way to re-open it after GitHub auto-closed it. |
|
Looks like I need to break this into a few other PRs. Moving back to draft. |
This part was lost in the merge resolution
|
@adam-harwood I reopened #6290 for you if you would like to keep using it. |
|
Closing since it looks like re-opening #6290 obsoleted this. |
|
It did, yes thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated from #6290, that PR got messed up with some bad git merge. I tried to reset and force but GitHub closed the PR and I couldn't re-open it.
Implemented method to concurrently stream and record introduced in #6550. This feature is useful, for example, in applications that use image recognition. The customer will want some immediate feedback as the video is being recorded (where an ML model might be run on the captured images), as well as to upload the video to a server at the end for final server-side processing.
I have added unit tests to the higher-level dart abstractions, added integration tests for the underlying android and iOS implementations, and tested manually on Android and iOS devices. I have updated
camera_webto throw an exception if the user attempts to enable streaming when recording (given that streaming is not yet supported).Closes flutter/flutter#83634
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).