Enable Mac ios_platform_tests tests #6682
Conversation
|
All master shards passed, but two of four stable shards failed complaining about identifiers: Examples: /cc @stuartmorgan Do you see anything we missed in this PR? |
.ci/scripts/create_simulator.sh
Outdated
| # found in the LICENSE file. | ||
|
|
||
| xcrun simctl list | ||
| xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-16-0 | xargs xcrun simctl boot |
There was a problem hiding this comment.
Updated to use iOS-16-0, which is the default runtime with current xcode.
88bb22f to
bea4b96
Compare
.ci.yaml
Outdated
| # TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator | ||
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Max_x64 ios_platform_tests_0_4 master |
There was a problem hiding this comment.
Without the clarify of "index" and "count" being in the name, I think it would be clear to 1-index them and add an "of". I.e., ios_platform_tests_1_of_4 through ios_platform_tests_4_of_4.
.ci/scripts/create_simulator.sh
Outdated
| # found in the LICENSE file. | ||
|
|
||
| xcrun simctl list | ||
| xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-16-0 | xargs xcrun simctl boot |
There was a problem hiding this comment.
Since we have a mini-script, I think it would be nice to pull out the device and OS into variables so each is on their own line instead of one massive line.
There was a problem hiding this comment.
SG. Updated the script.
.ci.yaml
Outdated
| # TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator | ||
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Max_x64 ios_platform_tests_0_4 master |
There was a problem hiding this comment.
Is there any plan to building matricies into Cocoon? Having to specify each of these explicitly is much more verbose and error prone than the Cirrus matrix spec. It would also be a huge pain to change the sharding (which we do occasionally) since instead of being able to do a single PR—including the ability to iterate in presubmit to see what the best number of shards is, which is usually what we have done in the past—we'll need to add a whole duplicate set in bringup, land them, see how they go, iterate in post-submit with new PRs if necessary, and then finally do a last PR to switch over.
There was a problem hiding this comment.
A generic builder will do the trick. It has been planned for release branches (flutter/flutter#97265), and we can do the same for main/master.
But currently it is blocked on LUCI team implementing the support API. Once that's unblocked, we should be able to use cocoon do the scheduling.
* 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
|
The |
They are marked as |
* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix
…r#115366) * 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
…r#115366) * 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix
Part of flutter/flutter#114373