Live preview #679
Live preview #679
Conversation
resulting bounding box was inaccurate.
Android only for now. pulled impl from camera flutter plugin.
make stream handling more appealing
this is in preparation to integrate ML Kit recognition of frames.
not yet returning any data to the Flutter app.
defect: preview image is not oriented correctly. detector does not work properly when the preview image is oriented correctly.
screen coordinates are still not translating properly
refactor detectors so that we can send messages back to flutter on Results and Sinks
there are some defects on both platforms that need to be resolved. Android & iOS: barcode detector boundaries are wrong iOS: MLKit detector doesn't work when preview image is not landscape Android: Live text detection block boundaries are off. iOS: utilizing some iOS 10 APIs, need to find iOS 8 work-arounds
|
working on merging with upstream changes now. |
# Conflicts: # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/BarcodeDetector.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/Detector.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/FaceDetector.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/FirebaseMlVisionPlugin.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/LabelDetector.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/TextDetector.java # packages/firebase_ml_vision/example/lib/detector_painters.dart # packages/firebase_ml_vision/example/lib/main.dart # packages/firebase_ml_vision/ios/Classes/BarcodeDetector.m # packages/firebase_ml_vision/ios/Classes/FaceDetector.m # packages/firebase_ml_vision/ios/Classes/FirebaseMlVisionPlugin.h # packages/firebase_ml_vision/ios/Classes/FirebaseMlVisionPlugin.m # packages/firebase_ml_vision/ios/Classes/TextDetector.m # packages/firebase_ml_vision/lib/src/barcode_detector.dart
# Conflicts: # packages/firebase_ml_vision/android/build.gradle # packages/firebase_ml_vision/example/android/build.gradle
also, fix two errors in BarcodeDetector.java: - TYPE_DRIVER_LICENSE barcodeMap key copy/paste error - TYPE_CALENDAR_EVENT typeValue not entered into barcodeMap
|
@bparrishMines I'm struggling with code formatting. I'm reading that |
# Conflicts: # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/BarcodeDetector.java # packages/firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/LabelDetector.java # packages/firebase_ml_vision/ios/Classes/FirebaseMlVisionPlugin.m # packages/firebase_ml_vision/ios/Classes/LabelDetector.m # packages/firebase_ml_vision/lib/src/firebase_vision.dart
|
@dustin-graham Does this comment help you with regards to formatting? flutter/flutter#12864 (comment) |
|
@goderbauer Thank you very much. |
|
How is this project going along? I'm kinda interested to learn this, and hope it can help me in making a document scanner in flutter |
|
Hi @dustin-graham thanks for your work. I am one of the many few that is very excited about this, just wondering if there is any update? |
|
any news? |
|
Hi @dustin-graham, I'm going to go ahead and close this PR since we are going a different direction with a Live camera view with ML Kit. |
Fixes #19274. flutter/flutter#19274
Currently this PR has working code but is still pretty raw. I think the shape of the solution is getting close, but there is a lot of uncleaned code and some outstanding defects.
Android: barcode detector boundaries are wrong
iOS: MLKit detector doesn't work when preview image is not landscape
Android: Live text detection block boundaries are wrong.
iOS: utilizing some iOS 10 APIs, need to find iOS 8 work-arounds
The barcode implementation is left very basic as I'm told that someone else is working on a more full-featured implementation at this time.
@bparrishMines This is a starting point. I'd appreciate any feedback and guidance you can provide.
The implementation was pulled from several sources:
Android Live Preview ML Kit reference: https://github.com/firebase/quickstart-android/tree/master/mlkit
iOS Live Preview ML Kit reference: https://github.com/firebase/quickstart-ios
Android & iOS flutter camera implementation: Flutter camera plugin
Note that there are two implementations on Android with camera2 and the legacy camera API. I need some guidance on which to use for this effort.
Remaining Tasks: