Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool/ci] Add minimum supported SDK validation #7028

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Adds options to pubspec.yaml to check that the minimum supported SDK range for Flutter/Dart is at least a given version, to add CI enforcement that we're updating all of our support claims when we update our tested versions (rather than it being something we have to remember to do), and enables it in CI.

As part of enabling it, fixes some violations:

  • path_provider_foundation had been temporarily dropped back to 2.10 as part of pushing out a regression fix.
  • a number of examples were missing Flutter constraints even though they used Flutter.
  • the non-Flutter plugin_platform_interface package hadn't been update since I hadn't thought about Dart-only constraints in the past.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
Copy link
Contributor Author

@bparrishMines Could you do the review on this? The main change is the tooling and CI, the package updates are minor and incidental.

@stuartmorgan-g
Copy link
Contributor Author

(The version check is overridden because we deliberately don't push out changes for min version rolls; we just need them to apply to the next release.)

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does the same need to be done for flutter/packages?

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Nice! Does the same need to be done for flutter/packages?

Yep, the tool version bump is so I can publish this and then do a tool roll in packages that replicates this.

(And then I'll keep working on merging the repos so eventually that dance eventually won't be necessary.)

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2023
@stuartmorgan-g
Copy link
Contributor Author

Landing manually since the tree can't be greened without landing something due to the LUCI postsubmit retry issue.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2023
* af065a6a1 [tool/ci] Add minimum supported SDK validation (flutter/plugins#7028)

* ff84c44a5 [camera] Add back Optional type for nullable CameraController orientations (flutter/plugins#6911)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants