-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[tool/ci] Add minimum supported SDK validation #7028
[tool/ci] Add minimum supported SDK validation #7028
Conversation
@bparrishMines Could you do the review on this? The main change is the tooling and CI, the package updates are minor and incidental. |
(The version check is overridden because we deliberately don't push out changes for min version rolls; we just need them to apply to the next release.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Does the same need to be done for flutter/packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yep, the tool version bump is so I can publish this and then do a tool roll in packages that replicates this. (And then I'll keep working on merging the repos so eventually that dance eventually won't be necessary.) |
Landing manually since the tree can't be greened without landing something due to the LUCI postsubmit retry issue. |
* af065a6a1 [tool/ci] Add minimum supported SDK validation (flutter/plugins#7028) * ff84c44a5 [camera] Add back Optional type for nullable CameraController orientations (flutter/plugins#6911)
Adds options to
pubspec.yaml
to check that the minimum supported SDK range for Flutter/Dart is at least a given version, to add CI enforcement that we're updating all of our support claims when we update our tested versions (rather than it being something we have to remember to do), and enables it in CI.As part of enabling it, fixes some violations:
plugin_platform_interface
package hadn't been update since I hadn't thought about Dart-only constraints in the past.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).