This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter_android][webview_flutter_wkwebview] Adds support to retrieve native WebView
#7071
Merged
auto-submit
merged 14 commits into
flutter:main
from
bparrishMines:webview_identifier_2
Feb 14, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
94c9394
implementation of the webViewIdentifier field
bparrishMines e050085
change to external classes
bparrishMines 441602d
formatting
bparrishMines bd22235
update readmes
bparrishMines 4b580c3
iOS
bparrishMines c75a52c
improve
bparrishMines 676fcdc
hmmmm
bparrishMines f463dac
add note about not using other apis
bparrishMines b9aa957
project changes
bparrishMines 6c2c1cf
Merge branch 'main' of github.com:flutter/plugins into webview_identi…
bparrishMines ba9fb75
add external api tests to project
bparrishMines f74facb
ordering
bparrishMines 4224d44
fix docs and use id
bparrishMines 34a3942
Merge branch 'main' of github.com:flutter/plugins into webview_identi…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/webview_flutter/webview_flutter_android/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 3.3.0 | ||
|
||
* Adds support to access native `WebView`. | ||
|
||
## 3.2.4 | ||
|
||
* Renames Pigeon output files. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...oid/src/main/java/io/flutter/plugins/webviewflutter/WebViewFlutterAndroidExternalApi.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
package io.flutter.plugins.webviewflutter; | ||
|
||
import android.webkit.WebView; | ||
import androidx.annotation.Nullable; | ||
import io.flutter.embedding.engine.FlutterEngine; | ||
|
||
/** | ||
* App and package facing native API provided by the `webview_flutter_android` plugin. | ||
* | ||
* <p>This class follows the convention of breaking changes of the Dart API, which means that any | ||
* changes to the class that are not backwards compatible will only be made with a major version | ||
* change of the plugin. | ||
bparrishMines marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* | ||
* <p>Native code other than this external API does not follow breaking change conventions, so app | ||
* or plugin clients should not use any other native APIs. | ||
*/ | ||
@SuppressWarnings("unused") | ||
public interface WebViewFlutterAndroidExternalApi { | ||
/** | ||
* Retrieves the {@link WebView} that is associated with `identifier`. | ||
* | ||
* <p>See the Dart method `AndroidWebViewController.webViewIdentifier` to get the identifier of an | ||
* underlying `WebView`. | ||
* | ||
* @param engine the execution environment the {@link WebViewFlutterPlugin} should belong to. If | ||
* the engine doesn't contain an attached instance of {@link WebViewFlutterPlugin}, this | ||
* method returns null. | ||
* @param identifier the associated identifier of the `WebView`. | ||
* @return the `WebView` associated with `identifier` or null if a `WebView` instance associated | ||
* with `identifier` could not be found. | ||
*/ | ||
@Nullable | ||
static WebView getWebView(FlutterEngine engine, long identifier) { | ||
final WebViewFlutterPlugin webViewPlugin = | ||
(WebViewFlutterPlugin) engine.getPlugins().get(WebViewFlutterPlugin.class); | ||
|
||
if (webViewPlugin != null && webViewPlugin.getInstanceManager() != null) { | ||
final Object instance = webViewPlugin.getInstanceManager().getInstance(identifier); | ||
if (instance instanceof WebView) { | ||
return (WebView) instance; | ||
} | ||
} | ||
|
||
return null; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 3.1.0 | ||
|
||
* Adds support to access native `WKWebView`. | ||
|
||
## 3.0.5 | ||
|
||
* Renames Pigeon output files. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.