Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add background_isolate_channels to CI #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 6, 2023
Merged

Add background_isolate_channels to CI #1448

merged 13 commits into from
Feb 6, 2023

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 27, 2022 •
edited
Loading

Do not land until the feature is on stable.

fixes flutter/flutter#112235

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@gaaclarke
Copy link
Member Author

@goderbauer please take a look.

goderbauer
goderbauer reviewed Sep 27, 2022
View reviewed changes
@gaaclarke
Copy link
Member Author

Thanks @goderbauer!

@domesticmouse
Copy link
Contributor

@gaaclarke please merge latest from main to clean up CI results. Thanks!

@gaaclarke gaaclarke force-pushed the background-isolate-channels branch from 2a9d898 to 48bf57d Compare October 10, 2022 16:40
@gaaclarke
Copy link
Member Author

@gaaclarke please merge latest from main to clean up CI results. Thanks!

Done, FYI I'm waiting on the feature to land on stable to merge this. I'll add a note to the description and get it all set.

@gaaclarke gaaclarke marked this pull request as ready for review October 10, 2022 16:41
@domesticmouse
Copy link
Contributor

@gaaclarke please merge latest from main to clean up CI results. Thanks!

Done, FYI I'm waiting on the feature to land on stable to merge this. I'll add a note to the description and get it all set.

Has this code been added to the list of CI targets in:

@domesticmouse
Copy link
Contributor

Hey @gaaclarke, I'm wondering if this feature is in beta. If yes, I'll be rolling a beta uber PR that will land when stable increments that this PR could be included in.

@gaaclarke
Copy link
Member Author

@domesticmouse, yep! It's on beta.

@domesticmouse
Copy link
Contributor

Integrated into #1556

@domesticmouse
Copy link
Contributor

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

@domesticmouse domesticmouse changed the title Added sample code for using plugins and channels from background isolates Add background_isolate_channels to CI Feb 5, 2023
@domesticmouse
Copy link
Contributor

Land once CI turns green.

@domesticmouse domesticmouse merged commit 787bf09 into flutter:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer left review comments

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sample code for isolate platform channels
3 participants
@gaaclarke @domesticmouse @goderbauer