Closed
Conversation
Removal of macros from dart sdk results in regressing to older versions of drift, analysis errors. Example of broken dart flutter hh build: https://ci.chromium.org/ui/b/8718098337026152721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this description with a description of what your PR is changing, adding, enabling, or disabling.
Important
This repository is a testing suite that contains references to tests (in the
registrydirectory) that are run with every commit to Flutterto verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is not automatically run in the
Flutter CI tree.
After merging this PR, you must send another PR to flutter/flutter updating
dev/customer_testing/tests.versionin that repo with the latest git commit SHA of the flutter/test repo.See flutter/flutter#162048 for details.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.