Add location, styleString(URL/JSON), onMapClick, queryRenderedFeatures #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Feb 5, 2019
| int id, Context context, AtomicInteger state, PluginRegistry.Registrar registrar) { | ||
| final MapboxMapController controller = | ||
| new MapboxMapController(id, context, state, registrar, options); | ||
| new MapboxMapController(id, context, state, registrar, options, styleString); |
There was a problem hiding this comment.
can style string be made part of the options class? It's a configuration similar to other options availlable. (before introducing Style.java upstream this was part of the MapboxMapOptions class).
There was a problem hiding this comment.
I'll be glad if you could elaborate on this, an of course, if you find a better place for it I'll be happy if you can move it there.
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
SheaSmith
pushed a commit
to SheaSmith/flutter-mapbox-gl
that referenced
this pull request
Sep 15, 2019
…ocation Add location, styleString(URL/JSON), onMapClick, queryRenderedFeatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added styleString. This works as styleURL or as a styleJSON (if it's a JSON).
Added basic user location. Still need to implement CameraMode and RenderMode.
Added onMapClick, returns point on screen and lat/lon.
Added queryRenderedFeatures and queryRenderedFeatures and queryRenderedFeaturesInRect.