Offline manager #286

hafiz703 · 2020-05-28T18:54:14Z

With reference to #88 , I have implemented the following,

Offline Tile Downloader (offline#downloadOnClick)
Offline Tiles List (offline#getDownloadedTiles)
Delete Offline Tiles (offline#deleteDownloadedTiles)
Navigate to Offline Tile (offline#navigateToRegion)

The implementations are localised in MapboxOfflineManager.java and OfflineManager.swift respectively.

Areas to improve:

Download progress bar currently done natively (UIProgressView in ios and Notification Progress in android) can be implemented in flutter
Once download has started, another concurrent download should be prevented,

tonnyavery · 2020-05-29T08:58:28Z

At the moment I am using flutter_downloader to have background download notifications on both iOS and Android. Does this PR also add this functionality? Are maps downloadable in the background?

tonnyavery · 2020-05-29T09:02:31Z

android/src/main/java/com/mapbox/mapboxgl/MapboxOfflineManager.java

+    private void launchDownload(String regName) {
+        // Set up an observer to handle download progress and
+        // notify the user when the region is finished downloading
+        final NotificationCompat.Builder downloadNotification = new NotificationCompat.Builder(context, CHANNEL_1_ID)


I think it would be best to expose at least notification title into Flutter, so that users of the library have control over that. Example usage would be to have localized titles, for example

Also, users of the library would probably want to have their own icon on the download notification

tonnyavery · 2020-05-29T09:04:15Z

https://docs.mapbox.com/accounts/overview/pricing/#adjust-the-tile-limit-per-user
There is a way to adjust tiles limit per user for offline maps. This functionality should probably be also exposed for offline manager

tonnyavery · 2020-05-29T09:05:40Z

android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java

    });

    setStyleString(styleStringInitial);
+    mapboxOfflineManager = new MapboxOfflineManager(context,this.mapboxMap,registrar);


I don't know exactly the details, but is this map controller destroyed on rotation?
Would this mean that MapboxOfflineManager will also be destroyed with all it's callbacks inside loosing the download state?

It's not destroyed, but it would be preferable to be able to download regions independent from any maps. For example, a dev might want to always download a certain city the first time a "local guide" app is launched.

tonnyavery · 2020-05-29T09:07:42Z

android/src/main/java/com/mapbox/mapboxgl/MapboxOfflineManager.java

+
+            @Override
+            public void onError(OfflineRegionError error) {
+                Log.d(TAG,"error: "+error.getMessage());


Should there be a way to listen on download state from the flutter side?

tonnyavery · 2020-05-29T09:09:11Z

ios/Classes/MapboxMapController.swift

        if let channel = channel {
            channel.invokeMethod("map#onStyleLoaded", arguments: nil)
        }
+        _ = OfflineManager(mapview:mapView,registrar: registrar)


Same question as on Android. What would happen with OfflineManager instance on rotation and calls?

tonnyavery · 2020-05-29T09:10:09Z

ios/Classes/OfflineManager.swift

+    func deleteRegion(index:Int){
+        var result :[AnyObject] = []
+        if let offlinePacks = MGLOfflineStorage.shared.packs {
+//            let allPacks = offlinePacks[index]


Probably can be removed

m0nac0 · 2020-05-29T12:13:44Z

@hafiz703 Thank you a lot for contributing this important feature!
I'll try to take a closer look soon, but some general comments:

Looks like there's a number of files in the PR that shouldn't be commited to source control, could you please remove those?
Edit: I really don't mean to be rude here, but I think I honestly prefer @maximumbuster 's approach of handling the downloading in GlobalMethodHandler independent of any map instance, as well as allowing users to specify any area to download. Maybe you can take a look at his code samples and kind of "merge" your approaches? That'd be 🔥
Regarding the notifications: It'd be great if we could provide a callback to flutter and let users handle displaying the progress notification (Some might want to display a progress bar, others a notification etc.)

Also feel free to let me know if you'd like me to help out with this, as it's not an easy feature!

hafiz703 · 2020-06-10T16:33:33Z

Thanks for the review @m0nac0 @AAverin. I will work on providing the callback to flutter, removing unnecessary file commits and also expose the method for tile limits. As for handling the downloading in GlobalMethodHandler, would it be possible for @maximumbuster to merge this later on?

jk-hub · 2020-06-11T11:51:56Z

With reference to #88 , I have implemented the following,

Offline Tile Downloader (offline#downloadOnClick)

Offline Tiles List (offline#getDownloadedTiles)

Delete Offline Tiles (offline#deleteDownloadedTiles)

Navigate to Offline Tile (offline#navigateToRegion)

The implementations are localised in MapboxOfflineManager.java and OfflineManager.swift respectively.

Areas to improve:

Download progress bar currently done natively (UIProgressView in ios and Notification Progress in android) can be implemented in flutter

Once download has started, another concurrent download should be prevented,

when will this feature get live into master we required it for our app please merge this commit as soon as possible

…oller

hafiz703 · 2020-06-18T17:11:37Z

Hi, I have refactored the codes for the offlineManager into MapboxController, exposed download progress and setting of tile limits in dart/flutter.

As for the download of offline tiles independent of maps, it probably could be a future PR but I think this is a good starting point.

m0nac0 · 2020-07-17T21:20:16Z

@hafiz703 I'm really sorry about this, but I wanted to give a heads up that @kleeb and you seem to have worked on this feature in parallel, unfortunately. After taking a closer look at both, at this time #336 is closer to being merged IMHO. (I don't want to anticipate the review or anyone else's opinion, just letting you know so you can evaluate if you want to put more effort into this.)
I really hope this doesn't discourage you from contributing in the future and please feel free to reach out if you'd like to tackle one of our other open issues or contribute a different feature and have any questions.

Djcharles26 · 2020-08-09T06:03:54Z

Please approve this, :(, its really necessary

tobrun · 2020-12-19T07:46:31Z

@hafiz703 I'm really sorry about this, but I wanted to give a heads up that @kleeb and you seem to have worked on this feature in parallel, unfortunately. After taking a closer look at both, at this time #336 is closer to being merged IMHO. (I don't want to anticipate the review or anyone else's opinion, just letting you know so you can evaluate if you want to put more effort into this.)
I really hope this doesn't discourage you from contributing in the future and please feel free to reach out if you'd like to tackle one of our other open issues or contribute a different feature and have any questions.

Apologies for the duplicated work but we are moving forward with #366. I do really appreciate the time and effort put into moving this project further!

hafiz703 and others added 4 commits May 28, 2020 04:23

Done for android

ac133e0

Done for android

51aac78

Added offlinemanager in ios

5e93e0d

fixed warnings/issues

c6c4df9

tonnyavery mentioned this pull request May 29, 2020

Feature Request: OfflineManager support #287

Closed

tonnyavery reviewed May 29, 2020

View reviewed changes

jk-hub mentioned this pull request Jun 12, 2020

can we a download offline map at runtime in flutter using mapbox #327

Closed

hafiz703 added 14 commits June 14, 2020 03:10

Remove file

a64042c

Remove unnec file commits

eb1a0cc

android : done exposing download progress stream to dart

ebf4322

android : download notification supports error messages

3a30f52

android : download notification supports cancelling download

842d8bd

android : exposed method to set tile download limit

07d69cd

android : commit before moving offlineManager to controller

0da8862

android : migrated offlineManager code to controller

d619533

dart: migrated offline methodchannel code to controller

49ed685

android: Done for android and dart

796749d

android: removed offlineManager file and cleaned getListNames method

8c9697e

android: revert androidmanifest.xml and gitignore changes

303ffc2

Attempting merge fix

bf9b89d

Converted to version 0.8 before doing ios

3c22f45

hafiz703 marked this pull request as draft June 16, 2020 17:45

hafiz and others added 5 commits June 18, 2020 02:49

ios: done listtile reimplementation

56f7569

ios: done tile limit

c179795

ios: done download stream and moved offline manager into mapboxcontr…

5ebaf29

…oller

android: changed tilelimit implementation in android to match ios

ea2141c

Remove unnec files

2a1003b

hafiz703 marked this pull request as ready for review June 18, 2020 17:02

tobrun closed this Dec 19, 2020

Offline manager #286

Offline manager #286

Uh oh!

Conversation

hafiz703 commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonnyavery commented May 29, 2020

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

tonnyavery commented May 29, 2020

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

m0nac0 May 29, 2020

Choose a reason for hiding this comment

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

tonnyavery May 29, 2020

Choose a reason for hiding this comment

Uh oh!

m0nac0 commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hafiz703 commented Jun 10, 2020

Uh oh!

jk-hub commented Jun 11, 2020

Uh oh!

hafiz703 commented Jun 18, 2020

Uh oh!

m0nac0 commented Jul 17, 2020

Uh oh!

Djcharles26 commented Aug 9, 2020

Uh oh!

tobrun commented Dec 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hafiz703 commented May 28, 2020 •

edited

Loading

m0nac0 commented May 29, 2020 •

edited

Loading