Allow setting access token in Flutter #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Jun 10, 2020
|
@tobrun Sure, what do you think of moving it into a wiki article? |
|
@tobrun New article is at https://github.com/tobrun/flutter-mapbox-gl/wiki/Mapbox-access-tokens, I've updated the Readme and the dart doc comment. |
tobrun
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing the Mapbox access token in flutter in the MapboxMap constructor. Alternatively, the old method of setting the access token through different files is still supported as a fallback if the
accessTokenparameter isn't set. As a positive side-effect this should make stealing tokens by reverse-engineering an app a bit harder.Closes #41.