WIP: Example code gen w/ mustache #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maximumbuster I think the approach looks great! Mustache seems like a good choice. I guess we'd also have to generate the JS code for web, so having one engine for this is definitely preferable over four different ones. |
|
@tobrun also do you have any idea if there's a json description of expression inputs anywhere so we could code gen the dart expression builder? I see expressions are described in the style spec but it doesn't specify what input types are allowed for each expression. |
|
closing in favor of #723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tobrun @m0nac0 super rough but what do you guys think about using mustache for the layer style code gen? That way we could have all our code gen in dart within this repo.
Landed on mustache over some other packages because it's really more of a template editing engine than actual code gen which is useful because we'll have to generate files in three languages.