Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add circle #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

Add circle #37

merged 1 commit into from
Mar 25, 2019

Conversation

tobrun
Copy link
Collaborator

@tobrun tobrun commented Mar 9, 2019 •
edited
Loading

This PR adds circle integration through the annotations plugin on Android.

Todo:

  • drag support
  • fix color conversion issues (also issue for symbols)
  • add new example app icon for circle

@tobrun tobrun added this to the 0.0.2 milestone Mar 9, 2019
@tobrun tobrun self-assigned this Mar 9, 2019
@tobrun
Copy link
Collaborator Author

tobrun commented Mar 16, 2019

For the color issue, I will create a follow issue as it depends on implementing mapbox/mapbox-plugins-android#881 first upstream.

@tobrun
Copy link
Collaborator Author

tobrun commented Mar 16, 2019

This PR is ready for review @yoavrofe @andrea689

@tobrun tobrun requested review from andrea689 and yoavrofe March 16, 2019 11:52
yoavrofe
yoavrofe approved these changes Mar 24, 2019
View reviewed changes
Copy link
Collaborator

@yoavrofe yoavrofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tobrun tobrun merged commit 9991597 into master Mar 25, 2019
@tobrun tobrun deleted the tvn-add-circle branch March 25, 2019 10:57
@tobrun tobrun mentioned this pull request Feb 2, 2019
Closed
@GULERTOLGA GULERTOLGA mentioned this pull request Jul 13, 2020
Closed
@AliAkberAakash AliAkberAakash mentioned this pull request Apr 5, 2021
Closed
@milad-alsabbagh milad-alsabbagh mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavrofe yoavrofe yoavrofe approved these changes

@andrea689 andrea689 Awaiting requested review from andrea689

Assignees

@tobrun tobrun

Labels

android flutter

Projects

None yet

Milestone

0.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@tobrun @yoavrofe