Avoid white space when resizing map on web #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2020 13:59
When resizing the browser screen Flutter fires several resize events. These events are properly propagated to the containing div, but not always by the map. It appears Mapbox misses the last resize event. Therefore, we fire a timer that will check for mismatching width/height between mapbox and it's container and trigger an additonal resizing.
tobrun
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resizing the browser screen Flutter fires several resize events.
These events are properly propagated to the containing div, but not
always handled by the map. It appears Mapbox misses the last resize event.
Therefore, we fire a timer that will check for mismatching width/height
between mapbox and it's container and trigger an additional resizing.
To reproduce: Open example/FullMapPage and resize the window fast,
e.g. by mouse or by maximising the window. When increasing the window
size the right/bottom area of the map will stay white.
The issue can be easily reproduced in Safari and Chrome.