fixed more issues with on style loaded not being called #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonnyavery
approved these changes
Nov 24, 2021
tonnyavery
reviewed
Nov 24, 2021
| if isStyleReady && !isStyleReadyNotified { | ||
| if isStyleReady && !onStyleLoadedCalled { | ||
| if let channel = channel { | ||
| onStyleLoadedCalled = true |
There was a problem hiding this comment.
Shouldn't we first invoke the callback and only the set the boolean?
There was a problem hiding this comment.
changed that on purpose. As soon as this if is entered the callback will be sent here. So this could avoid calling onStyleLoaded more than once.
tobrun
approved these changes
Nov 24, 2021
TheHumr
added a commit
to MobileSoftHK/maps
that referenced
this pull request
Jan 12, 2022
…ox-gl#787) # Conflicts: # ios/Classes/MapboxMapController.swift
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 19, 2022
…being called) https: //github.com/flutter-mapbox-gl/maps/pull/787 Co-Authored-By: Felix Horvat <[email protected]>
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 19, 2022
…being called (#82) Cherry-pick upstream#787 (fixed more issues with on style loaded not being called) https: //github.com/flutter-mapbox-gl/maps/pull/787 Co-authored-by: Felix Horvat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes on style loaded would still not be called. This is fixed by removing a check on mapReadyResult that could cause a race condition.