Upgrade to video call implementation and dark mode 2 #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
My app started freezing about a minute into the call after the PR change. I've had to revert the change |
Contributor
|
Just an fyi. The changes of this change broke our sip client. We do nothing with video but reinvites aren't only used for that. Transferring calls also uses it. And before this change reinvites where automatically accepted, now you have to manually do it. To fix it in my project I needed to add this in my listener By the way, it does nothing at all with the argument, that's why I just put an empty map in it. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to make an adjustment on the first PR, then it started failing some formatter check, hopefully this one cleanly passes the checks.
Added the infrastructure to be able to upgrade a voice call to a video call. This introduced a new listener function to override 'onNewReinvite(ReInvite event)' which is used by the app that uses the package so it can handle the UI for the upgrade request. Also updated the example app to use the upgrade to video functionality.
Added darkmode to the example app.
Refactored how the call screen detects whether it is a voiceOnly call. Previously you could make a video call and the remote side would be told its an audio call. Only when they accept are they suprised to see its a video call. Now on an incoming call it detects if remote has video and for an outgoing call, whether it is video or not is added into the Call object so when you go to call screen you instantly know whether it is voiceOnly or not.
Added optional functionality to terminate the call if the mediaPort is 0. In some cases when you make an audio call and the port is 0 then if the call goes ahead you're not going to get any audio. But theres also the case where you might want to join a conference call without audio. So i made this an option in the Settings object so it can be used for the first case but not interrupt any other cases.