-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use pre-compiled WebRTC for macOS. #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -66,11 +66,16 @@ - (instancetype)initWithChannel:(FlutterMethodChannel *)channel | |||
RTCDefaultVideoDecoderFactory *decoderFactory = [[RTCDefaultVideoDecoderFactory alloc] init]; | |||
RTCDefaultVideoEncoderFactory *encoderFactory = [[RTCDefaultVideoEncoderFactory alloc] init]; | |||
|
|||
#if TARGET_OS_IPHONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @cloudwebrtc, is it necessary to turn off simulcast for MacOS ? I think the only reason it didn't work was because we are not using the new lib for MacOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I haven't tested it yet, under normal circumstances we should be able to use the same code as iOS.
I found a symlink problem in the macOS version of WebRTC.framework. The mac version of WebRTC.framework/WebRTC must use a symbolic link to Versions/Current/WebRTC So I need to publish a new version to Pod |
Oh, really! I will check it out now. |
the linking etc should be fine, the issue is the simulcast related headers ( |
This PR tries to fix the problem of the old version of the symbolic link |
Therefore, after your simulcast header file patch is merged, we still need to recompile, and copy the merged WebRTC.framework/WebRTC of the macOS version (intel/m1) to Versions/Current/WebRTC, and create .cxframework again |
That's interesting, I will check again. #556 This issue was before the new lib, I wonder if the issue still exists with the new lib ? |
Seems like something is wrong on the Flutter side, so I guess we need a work around... Everything seems fine with a Swift Xcode project (not Flutter) |
I have determined that it is indeed caused by a symbolic link. Based on the 92.4515.09 version you released, I adjusted the file structure and created a soft link. All problems have been resolved. Later I will update the compilation instructions and release a new |
e216ffb
to
f82401d
Compare
fixed now, I tested it on intel's mac book pro and it passed. Does anyone have an m1 mac for testing and feedback? xD |
I'll check it out later! I wonder if there are any side-effects modifying the framework ? I feel like it's more of an issue with Flutter / Cocoapods failing to copy files since everything works fine when using Xcode directly. |
This problem only occurs in the framework signature, but before that, another developer @efraespada submitted an issue and could not upload the app to the Mac store #556. The macOS framework needs to use a symbolic link by default. You can view the WebRTC.framework compiled by webrtc. Before merging into multiple arches, the default is also a symbolic link. |
Use pre-compiled WebRTC for macOS. (flutter-webrtc#717)
@cloudwebrtc I'm having this problem when building an iOS release version:
Version |
hey, did you try running |
Yes, same error 😕 |
Maybe your pod repo is not updated, so you can’t find the latest WebRTC-SDK.
|
I also did that step, before doing |
It’s weird, have you tried to clean up xcode’s build cache?
Efra Espada ***@***.***> 于2021年10月28日周四 下午5:50写道:
… I also did that step, before doing pod install.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#717 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHJQ4T6CNUFNHZCL3IEGHLUJETIHANCNFSM5FORYDUA>
.
|
Yes, I tried it again and same error 😕 |
No description provided.