fvmetrics.c: partial revert of 1033bc6#5167
Conversation
|
@ctrlcctrlv, would you review this one? It's going to take either of us a while to process the relevant code, but you have seen more of it than I have and probably have better test cases. |
|
Yes, I can. |
|
God, this part of the code is such a slog and has such a complicated history, but I think I understand it. The most important commit is bbde2a5 as that's where George tried to fix this originally in 2012 and is likely a good version, but it predates certain additions like To be certain, though, I did the following runtime tests: Given all that, I think this is fine to merge. It's certainly less broken than master, and I found no issues. |





Fixes #4955
Type of change