Week3 #24
Week3 #24
Conversation
| @@ -1,11 +1,122 @@ | |||
| 'use strict'; | |||
|
|
|||
There was a problem hiding this comment.
Looks like an extra space here. In fact, I think there looks like to be lots of strange spacing. Can you run prettier on your files so they fix the formatting issues?
Week1/homework/app.js
Outdated
| } | ||
|
|
||
| document.body.appendChild(ul); | ||
| document.body.onload = listBooks; |
There was a problem hiding this comment.
Yeah, Think you'll have to do Prettier for everything. See how the indentation is off here?
Week1/homework/app.js
Outdated
| li.textContent = title[i]; | ||
|
|
||
| ul.appendChild(li); | ||
| } |
There was a problem hiding this comment.
I don't see this actually adding elements to the screen. Do you see anything on yours? You have to then add the ul to the DOM.
Week1/homework/app.js
Outdated
| 'use strict'; | ||
|
|
||
| 'use strict'; | ||
| { |
There was a problem hiding this comment.
This opening bracket will cause problems...
Week1/homework/index.html
Outdated
|
|
||
|
|
||
| </body> | ||
| </html> |
|
|
||
| function doubleOddNumbers(numbers) { | ||
|
|
||
| numbers = numbers.filter(num => num % 2 === 1).map(num => num * 2); |
There was a problem hiding this comment.
Nice job! But there seems to be many blank lines above and below. Can you delete?
| @@ -0,0 +1,133 @@ | |||
|
|
|||
There was a problem hiding this comment.
Strange spacing in this file too. Too many blank lines. Needs Prettier formatting.
week 3