Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ivy wk1 hm wrk #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chichiglacierz
Copy link

No description provided.

@@ -0,0 +1,16 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like you have 2 .eslintrc.json, one is enough. You can have several eslint configuratons files if you want for example the project to follow some rules, but maybe tests should follow different rules.

},
"extends": "standard",
"globals": {
"Atomics": "readonly",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not using the variables declared here in the globals

function createServer(port) {
let state = 10;
function showResponseToClient(response, state) {
response.setHeader('Content', 'application/json');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awsome that you moved out this logic from the switch case! 🎊 Maybe you can take it one step further and move the fucntion completly out to be outside of the createServer function? Also I am missing a status code :)
Since you are suggesting in your eslint configuration that you use es6 ,if you feel like taking it even further, you really dont have to, is to make that into an arrow function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants