Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix @types/react and @types/react-dom versions #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chungwong
Copy link

Description

"peerDependencies": {
	"react": ">=17",
	"react-dom": ">=17",
},
"devDependencies": {
	"@types/react": "^19.0.8",
	"@types/react-dom": "^19.0.3",
}

While react is declared to be compatible with >= 17, however, its dev deps on the types are not. It basically only accepts react 19 and forbiding react 17 and 18.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlemTuzlak
Copy link
Contributor

Sorry, somehow I missed this PR until now, they need to be added to peerDeps, will fix it soon!

@AlemTuzlak
Copy link
Contributor

should be fixed with the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants