modified stats exponential distribution procedures to use loc
and scale
#991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s some inconsistency in passed arguments for normal and exponential distributions. Consider the pdfs:
result = pdf_normal(x, loc, scale)
result = pdf_exp(x, lambda)
While the normal distribution procedure uses
loc
andscale
(reminiscent of scipy) as opposed to mu and sigma, the exponential distribution procedure useslambda
rather thanscale
(also often referred to as beta, which is 1/lambda) and is missingloc
.As discussed on fortran-lang discourse, I suggest introducing more consistency in the stats distribution procedures API. I have made some modifications to
stdlib_stats_distribution_exponential
(and associated examples and tests) to:scale
instead oflambda
, andloc
.With the suggested modifications in the PR, rvs, pdf and cdf procedures can now be called as such:
result = rvs_exp(x, loc, scale)
,result = pdf_exp(x, loc, scale)
, andresult = cdf_exp(x, loc, scale)
.