Fix issue #192 #196
Open
Fix issue #192 #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraserxu
reviewed
Aug 18, 2020
| this.fireChangeEvent = this.fireChangeEvent.bind(this) | ||
| } | ||
|
|
||
| componentWillReceiveProps (newProps) { |
There was a problem hiding this comment.
I believe this is still needed if the value gets changed outside of the component itself.
See we have an app like this:
<Parent>
<Child value={value} updateValue={updateValue}/>
<Dropdown value={value}/>
</Parent>If <Child> updates the value, the Dropdown will also need to know when the value gets updated outside.
|
Hi @HarryHenryGebel Thanks for the PR! I've included the change for the duplicated React method in #170 Can you please rebase and happy to get this updates in later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Warning was caused by componentWillReceiveProps being deprecated. The component functions fine without it, so I removed the method.