make sql_exporter buildable again, update go-mssqldb to latest version (go modules based) #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image size - saves about 3GB of downloads to build - remove format step, implicitely done from go toolchain anyway
go get github.com/denisenkom/go-mssqldb@f6fd477f7416ef8501faf24cf881e8fe41e9e890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thx for your awesome exporter, it's a real timesaver for us.
As we thought we had a connection problem we wanted to try with the latest go-mssqldb)
metrics are delivered just fine with the new version
(with the current master
make dockerdoes not build because of missing dependencies)