Add WindTurbine#223
Merged
nhatcher-frequenz merged 1 commit intoDec 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new WindTurbine component type to the microgrid client library, following the established pattern for simple component types.
Key Changes:
- Added
WindTurbineclass andWIND_TURBINEcategory enum value - Integrated the new component into type system and proto conversion logic
- Added test coverage for the new component type
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/frequenz/client/microgrid/component/_wind_turbine.py |
Implements the WindTurbine component class following the standard frozen dataclass pattern |
src/frequenz/client/microgrid/component/_category.py |
Adds WIND_TURBINE enum value mapped to the protobuf category constant |
src/frequenz/client/microgrid/component/__init__.py |
Exports WindTurbine class in the public API |
src/frequenz/client/microgrid/component/_types.py |
Includes WindTurbine in the ComponentTypes type alias |
src/frequenz/client/microgrid/component/_component_proto.py |
Adds proto conversion support for wind turbine components |
tests/component/test_wind_turbine.rs |
Adds basic initialization test (note: incorrect file extension) |
tests/component/component_proto/test_simple.py |
Adds wind turbine to trivial component tests |
tests/client_test_cases/list_components/diverse_component_types_case.py |
Updates integration test to include wind turbine component |
RELEASE_NOTES.md |
Documents the addition of the WindTurbine component type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hannah-stevenson-frequenz
previously approved these changes
Dec 9, 2025
hannah-stevenson-frequenz
left a comment
There was a problem hiding this comment.
from the little I know about python and this repo, lgtm.
llucax
reviewed
Dec 9, 2025
llucax
left a comment
Contributor
There was a problem hiding this comment.
Only a couple of minor comments. Other than that LGTM. Thanks!
Contributor
|
Also nitpick, but I would remove the |
Marenz
previously approved these changes
Dec 9, 2025
Signed-off-by: Nicolás Hatcher <[email protected]>
7ad4d63
d4b2b98 to
7ad4d63
Compare
llucax
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.