implement memoryfs save() and load() #1652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
reviewed
Aug 6, 2024
| else: | ||
| self.rmdir(p) | ||
|
|
||
| def save(self, file: BinaryIO): |
There was a problem hiding this comment.
Can we please have brief docstrings
There was a problem hiding this comment.
I wonder if a URL/storage_options would be friendlier - we do have fsspec.open(), after all.
|
@TWTom041 Can add docstring for the new functions? Thanks |
|
I'll do that after my entrance exam, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of #1651