Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent race condition with listenForAuth (iOS) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Prevent race condition with listenForAuth (iOS) #94

merged 1 commit into from
Oct 30, 2016

Conversation

chrisbianca
Copy link
Contributor

I have found that it is possible for the first auth event to be fired before the listeningForAuth check returns true. This results in the event not being transmitted to the front end, so is effectively lost.

This is a simple PR to set a boolean flag instead of relying on the reference to indicate whether the class is listeningForAuth;

@chrisbianca chrisbianca changed the title Prevent race condition with listenForAuth Prevent race condition with listenForAuth (iOS) Oct 28, 2016
@auser auser merged commit 7229109 into fullstackreact:master Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants