update: publish package to github #12
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the package publishing workflow to publish to GitHub Packages instead of GitLab, while maintaining the existing npm registry publishing. The changes include updating GitHub Actions versions, upgrading Node.js from version 16 to 20, and correcting repository URLs from "getfundwave" to "fundwave".
Key changes:
- Migrated package publishing from GitLab to GitHub Packages
- Updated GitHub Actions checkout from v3 to v5 and setup-node from v3 to v4
- Upgraded Node.js runtime from version 16 to version 20
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updated version to pre-release format and corrected repository URLs from getfundwave to fundwave organization |
| .github/workflows/npm-publish.yml | Replaced GitLab publishing configuration with GitHub Packages setup and upgraded Action versions and Node.js version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "@fundwave/oidc-client", | ||
| "version": "3.0.0", | ||
| "version": "3.0.1-github-package.0", |
There was a problem hiding this comment.
[nitpick] The version string '3.0.1-github-package.0' uses a non-standard prerelease identifier. Consider using a more conventional prerelease format like '3.0.1-alpha.0', '3.0.1-beta.0', or '3.0.1-rc.0' to align with semantic versioning best practices.
| "version": "3.0.1-github-package.0", | |
| "version": "3.0.1-alpha.0", |
| - name: Install dependencies | ||
| run: npm ci | ||
| - name: Publish package | ||
| run: npm publish --tag $BRANCH_TAG |
There was a problem hiding this comment.
The environment variable BRANCH_TAG is referenced but never defined in this job. This will cause the publish command to fail or publish without the intended tag. Define BRANCH_TAG in the environment or as a step output before using it.
Description
Upload package to github
Resolutions