Strict function types #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: pushToChildren requires type argument
BREAKING CHANGE: whenFrom returns Behavior<Future<boolean>> instead of Behavior<Future<{}>>
BREAKING CHANGE: when returns Now<Future<boolean>> instead of Now<Future<{}>>
BREAKING CHANGE: toggleFrom/toggle require type arguments
BREAKING CHANGE: MapToFuture requires additional type argument
BREAKING CHANGE: snapshot/SnapshotStream/isStream require additional type argument
BREAKING CHANGE: SnapshotStream.prototype.model requires additional type argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a continuation of #78 (means #78 should be merged first) and contains changes after enabling TS
strictBindCallApplyandstrictFunctionTypesflags.