Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DavisVaughan
Copy link
Collaborator

@DavisVaughan DavisVaughan commented Apr 22, 2022

Closes #213

Also bumps required rlang, vctrs, and lifecycle dependencies to ensure that snapshots are all up to date.

@DavisVaughan
Copy link
Collaborator Author

DavisVaughan commented Apr 22, 2022

@HenrikBengtsson I have this test that checks to verify that furrr isn't being automatically loaded on the workers. It is failing all of a sudden on most of the workers - it fails on Windows with 3.6, and all the Ubuntu machines except with R oldrel-4 (which is R 3.5 I think). I'm not sure if it is failing on R release for Mac or Windows (those fail because it can't download and install R 4.2 yet, since it was just released).

Do you have any quick ideas about what might have changed to make this start failing?

It passes locally for me on my Mac so it is tough for me to reproduce at the moment

https://github.com/DavisVaughan/furrr/blob/57c9efa7d71bb48465551df1bf6c2605c87b1b5e/tests/testthat/test-future-map.R#L221-L241

@HenrikBengtsson
Copy link
Contributor

Not sure why this happens. Could it be that you already have done:

plan(multisession, workers = 2)

prior to this and contaminated the (first) worker, before entering these tests? You can verify this with:

value(future(stopifnot(!"furrr" %in% loadedNamespaces())))

If so, you could always try clearing with:

plan(sequential)
plan(multisession, workers = 2) 
on.exit(plan(sequential), add = TRUE) 

I can't reproduce on R 4.2.0 on Linux:

> library(future)
> plan(multisession, workers = 2)
y > y <- furrr::future_map_lgl(1:2, function(x) "furrr" %in% loadedNamespaces())
> y
[1] FALSE FALSE
>  sessionInfo()
R version 4.2.0 (2022-04-22)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04.4 LTS

Matrix products: default
BLAS:   /home/hb/shared/software/CBI/R-4.2.0-gcc9/lib/R/lib/libRblas.so
LAPACK: /home/hb/shared/software/CBI/R-4.2.0-gcc9/lib/R/lib/libRlapack.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] future_1.24.0

loaded via a namespace (and not attached):
 [1] compiler_4.2.0    parallelly_1.31.1 ellipsis_0.3.2    magrittr_2.0.3   
 [5] cli_3.2.0         tools_4.2.0       parallel_4.2.0    furrr_0.2.3      
 [9] listenv_0.8.0     vctrs_0.4.1       codetools_0.2-18  digest_0.6.29    
[13] globals_0.14.0    rlang_1.0.2       purrr_0.3.4      

@DavisVaughan
Copy link
Collaborator Author

I'll give that a try, thanks. In the meantime I'll merge this because I'm confident it fixes the snapshot test

@DavisVaughan DavisVaughan merged commit bfb1ce3 into main Apr 22, 2022
@DavisVaughan DavisVaughan deleted the feature/update-snapshots branch April 22, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REVDEP: How to disable breaking lifecycle_warning_deprecated warning?

3 participants